Repository navigation
feat(borders): use mapcode-ts-borders for border lookups - #12
Merged
Merged
Conversation
Replace the in-house FlatGeobuf/flatbush BoundaryService with mapcode-ts-borders 1.0.0. MAPCODE_BORDERS_PATH is now optional and defaults to the bundled data. The test fixture is rebuilt as an .mcb file with canonical territory codes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The service reads its borders from mapcode-ts-borders, so the data/*.fgb files are gone. README and .env.example describe the optional MAPCODE_BORDERS_PATH and add the 2.12.0 release notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is missing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The service did its own OpenStreetMap border lookups with a FlatGeobuf file, flatgeobuf and flatbush. The same lookups now live in the
mapcode-ts-borderspackage, so this service uses that package and deletes its own copy.What changed
mapcode-ts-borders1.0.0.BoundaryService, flatgeobuf and flatbush are removed.MAPCODE_BORDERS_PATHis no longer used, and the 4data/*.fgbfiles are removed.Scope
mapcode-ts-bordersrelease and a dependency bump.Blast Radius
Deployments need no config change. A
MAPCODE_BORDERS_PATHthat is still set is ignored, so it can be removed at any time.Verification
npm testpasses 746 tests. Only 2 expectations changed, both for renamed fixture codes.npm run startwith a.envthat still setsMAPCODE_BORDERS_PATH=./data/borders.fgbstarts, logsborders: OpenStreetMap 2026-05and answers requests.🤖 Generated with Claude Code